Bug 68992

Summary:

[GTK] missing WebKit2 support in run-gtk-tests

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	kling: review+

Philippe Normand

Reported 2011-09-28 03:38:46 PDT

The script assumes all tests are in Programs/unittests but the webkit2 tests and inside a webkit2 directory there.

Attachments
proposed patch (1.47 KB, patch) 2011-09-28 03:40 PDT, Philippe Normand	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2011-09-28 03:40:24 PDT

Created attachment 108997 [details] proposed patch

Carlos Garcia Campos

Comment 2 2011-09-28 03:45:28 PDT

Comment on attachment 108997 [details] proposed patch Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/*

Philippe Normand

Comment 3 2011-09-28 04:02:55 PDT

(In reply to comment #2) > (From update of attachment 108997 [details]) > Looks good to me. Now we should make sure all tests are named test*. Maybe we should move webkit1 test into a webkit directory so that we have Programs/unittests/webkit/* and Programs/unittests/webkit2/* Yes that would be better indeed. I think it could be done in a follow-up patch, I wanted to keep this one minimal to get the API tests back up on the bots.

Carlos Garcia Campos

Comment 4 2011-09-28 04:16:45 PDT

Yes, I meant in a following patch indeed.

Philippe Normand

Comment 5 2011-09-28 04:25:15 PDT

Committed r96214: <http://trac.webkit.org/changeset/96214>

Note You need to log in before you can comment on or make changes to this bug.