Bug 68984

Summary: "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, haraken, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
rebased patch for commit none

Kentaro Hara
Reported 2011-09-28 01:36:25 PDT
Just a follow-up fix for the bug 68345.
Attachments
Patch (3.63 KB, patch)
2011-09-28 01:38 PDT, Kentaro Hara 		darin: review+
DetailsFormatted DiffDiff
rebased patch for commit (3.73 KB, patch)
2011-09-28 16:56 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-28 01:38:47 PDT
Created attachment 108985 [details] Patch
Darin Adler
Comment 2 2011-09-28 09:31:45 PDT
Comment on attachment 108985 [details] Patch Next time, please say “why” in the change log, not just what you are changing.
Kentaro Hara
Comment 3 2011-09-28 16:56:13 PDT
Created attachment 109093 [details] rebased patch for commit
WebKit Review Bot
Comment 4 2011-09-28 17:00:32 PDT
Comment on attachment 109093 [details] rebased patch for commit Rejecting attachment 109093 [details] from commit-queue. haraken@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 5 2011-09-28 23:06:24 PDT
Comment on attachment 109093 [details] rebased patch for commit Clearing flags on attachment: 109093 Committed r96301: <http://trac.webkit.org/changeset/96301>
Note You need to log in before you can comment on or make changes to this bug.