Summary: | "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, dominicc, haraken, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kentaro Hara
2011-09-28 01:36:25 PDT
Created attachment 108985 [details]
Patch
Comment on attachment 108985 [details]
Patch
Next time, please say “why” in the change log, not just what you are changing.
Created attachment 109093 [details]
rebased patch for commit
Comment on attachment 109093 [details] rebased patch for commit Rejecting attachment 109093 [details] from commit-queue. haraken@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 109093 [details] rebased patch for commit Clearing flags on attachment: 109093 Committed r96301: <http://trac.webkit.org/changeset/96301> |