Bug 68971

Summary:

Introduce feature flags for incomplete input types

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Forms

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, darin, dglazkov, joepeck, jonlee, keishi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

65915

Bug Blocks:

29359

Attachments:

Description	Flags
Patch	none
Patch 2	none
Patch 3	none
Patch 4	none
Patch 5	none

Kent Tamura

Reported 2011-09-27 22:30:14 PDT

Discussed in http://www.mail-archive.com/webkit-dev@lists.webkit.org/msg16107.html I'd like to add the following feature flags: ENABLE_INPUT_TYPE_DATE ENABLE_INPUT_TYPE_DATETIME ENABLE_INPUT_TYPE_DATETIMELOCAL ENABLE_INPUT_TYPE_MONTH ENABLE_INPUT_TYPE_TIME ENABLE_INPUT_TYPE_WEEK

Attachments
Patch (41.94 KB, patch) 2011-09-27 22:51 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 2 (42.53 KB, patch) 2011-09-28 00:13 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 3 (42.59 KB, patch) 2011-10-03 03:19 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 4 (42.87 KB, patch) 2011-10-03 21:23 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Patch 5 (47.54 KB, patch) 2011-10-04 19:14 PDT, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Kent Tamura

Comment 1 2011-09-27 22:51:36 PDT

Created attachment 108966 [details] Patch

Kent Tamura

Comment 2 2011-09-27 23:06:30 PDT

(In reply to comment #1) > Created an attachment (id=108966) [details] > Patch With this patch, we keep to enable these input types only on Xcode platforms because I don't know it's ok to remove them from WebKit on OS X and iOS.

WebKit Review Bot

Comment 3 2011-09-27 23:47:41 PDT

Comment on attachment 108966 [details] Patch Attachment 108966 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9878566 New failing tests: fast/css/pseudo-in-range.html fast/css/pseudo-out-of-range.html fast/css/pseudo-in-range-invalid-value.html

Kent Tamura

Comment 4 2011-09-28 00:13:29 PDT

Created attachment 108976 [details] Patch 2 Skip some fast/css tests which contain type=date.

Kent Tamura

Comment 5 2011-10-03 03:19:24 PDT

Created attachment 109459 [details] Patch 3 rebased

Kent Tamura

Comment 6 2011-10-03 21:23:23 PDT

Created attachment 109579 [details] Patch 4 This patch disables the input types by default on all platforms.

Kent Tamura

Comment 7 2011-10-04 19:14:08 PDT

Created attachment 109729 [details] Patch 5 Enable the flags for iOS because iOS already has good UIs

Hajime Morrita

Comment 8 2011-10-04 21:04:29 PDT

Comment on attachment 109729 [details] Patch 5 It's sad to have such many enable flags... But I assume folks agreed this according to the thread: http://markmail.org/thread/gymjpm36avtufodf

WebKit Review Bot

Comment 9 2011-10-04 23:05:52 PDT

Comment on attachment 109729 [details] Patch 5 Clearing flags on attachment: 109729 Committed r96678: <http://trac.webkit.org/changeset/96678>

WebKit Review Bot

Comment 10 2011-10-04 23:05:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.