Bug 68961

Summary:

Get JSVALUE32_64 DFG JIT building on OS X.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, yuqiang.xian

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	ggaren: review+

Gavin Barraclough

Reported 2011-09-27 17:08:59 PDT

* Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file). * Forward-declare functions in DFGOperations.cpp * UNUSED_PARAM for unused arguments * NO_RETURN for unimplemented function that ASSERT_NOT_REACHED * Fix argument types handled by OpInfo constructor. * Use SYMBOL_STRING instead of STRINGIZE for asm symbols. * Add files to Xcode project.

Attachments
Fix (deleted) 2011-09-27 17:10 PDT, Gavin Barraclough	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2011-09-27 17:10:19 PDT

Created attachment 108937 [details] Fix

WebKit Review Bot

Comment 2 2011-09-27 17:11:56 PDT

Attachment 108937 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 7 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 3 2011-09-27 17:52:51 PDT

Comment on attachment 108937 [details] Fix r=me

Gavin Barraclough

Comment 4 2011-09-27 18:08:40 PDT

Fixed in r96175

Note You need to log in before you can comment on or make changes to this bug.