Bug 6895 – include exception names in JavaScript form of DOM exception

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Darin Adler]

We should include the exception names in the JavaScript exceptions created for DOM exceptions. This will make the JavaScript console much nicer for cases where it's reporting a DOM exception.

[Darin Adler]

Created attachment 6058 [details]
include exception name in message in JavaScript exception object

[Maciej Stachowiak]

Comment on attachment 6058 [details]
include exception name in message in JavaScript exception object

r=me

Should we consider adding human readable messages to the exception as well?

[Darin Adler]

Yes, I was thinking that would be a nice next step.

[Alexey Proskuryakov]

Shouldn't rangeExceptionNames should also start with a zero, like exceptionNames? 
+static const char * const rangeExceptionNames[] = {
+    "BAD_BOUNDARYPOINTS_ERR", "INVALID_NODE_TYPE_ERR"
+};

There is an extra semicolon in one line:
+  int nameTableSize;;

There already was a bug requesting such an improvement (bug 6745) - should it be marked as a duplicate now, or can rather be used to tracking further enchancements?

[Darin Adler]

(In reply to comment #4)
> Shouldn't rangeExceptionNames should also start with a zero, like
> exceptionNames? 
> +static const char * const rangeExceptionNames[] = {
> +    "BAD_BOUNDARYPOINTS_ERR", "INVALID_NODE_TYPE_ERR"
> +};

Yes, good catch!

> There already was a bug requesting such an improvement (bug 6745) - should it
> be marked as a duplicate now, or can rather be used to tracking further
> enchancements?

I think we should use that one to track further enhancement.