Bug 6894

Summary: add a Vector class
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal CC: gavin.sharp
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
implement Vector hyatt: review+

Maciej Stachowiak
Reported 2006-01-28 18:05:48 PST
We could use a good Vector class to replace Array, QPtrVector, QValueVector, and one-off hacks to do resizable buffers or static stack buffers. Attached is my first cut at this. It should be really efficient for both POD and non-POD types, and supports an inline buffer for "fixed-size stack buffer" use cases. Potentially useful things that are not in this version (yet): - detecting allocation failures - versions of fill, the constructor and append which take start and end iterators - fill-style append - swap - generalized insert/remove (won't add these until it is clear they are needed) - reverse iterators (is this really at all useful?) - optional bounds checking w/ compile time switch - debug mode iterator checking like for HashTable
Attachments
implement Vector (30.64 KB, patch)
2006-01-28 18:09 PST, Maciej Stachowiak 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-01-28 18:09:49 PST
Created attachment 6055 [details] implement Vector
Dave Hyatt
Comment 2 2006-01-28 18:15:04 PST
Comment on attachment 6055 [details] implement Vector r=me, since you're turning it on and actually using it, make sure to run perf tests. We want to be really sure it's fast.
Note You need to log in before you can comment on or make changes to this bug.