Summary: | [Chromium] Fixed layout mode tests break subsequent tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||
Component: | Tools / Tests | Assignee: | Mihai Parparita <mihaip> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, fsamuel | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mihai Parparita
2011-09-27 11:57:24 PDT
Thanks for catching this. This should be a one-liner in Tools/DumpRenderTree/chromium/LayoutTestController.cpp. LayoutTestController::reset() that sets m_shell->webView()->enableFixedLayoutMode(false); Thanks again. Created attachment 108879 [details]
Patch
Wasn't sure about where to do this resetting (where you mentioned vs. WebViewHost::reset() vs. TestShell::resetTestController()). I ended up going with the latter, since it's where we also reset page scaling, which seems similar. Committed r96147: <http://trac.webkit.org/changeset/96147> |