Bug 68922 – Paginated floats should not grow the height of a block when they don't end up being tied to a line.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Paginated floats should not grow the height of a block when they don't end up being tied to a line. Floats encountered in skipLeadingWhitespace that paginate can't immediately grow the height of the block, since there may not end up being any actual line content. We only want to push the height of the block down if we have actual line content that we want to keep with the float.

[Dave Hyatt]

Created attachment 108877 [details]
Patch

Comment on attachment 108877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108877&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2696
> +        lineInfo.setFloatPaginationStrut(lineInfo.floatPaginationStrut() + paginationStrut);

I am surprised, without looking at the rest of the code, that the right thing to do here is to add, not to max(). It would be nice to have a test case with two floats that exercises this.

[Dave Hyatt]

(In reply to comment #2)
> (From update of attachment 108877 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108877&action=review
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2696
> > +        lineInfo.setFloatPaginationStrut(lineInfo.floatPaginationStrut() + paginationStrut);
> 
> I am surprised, without looking at the rest of the code, that the right thing to do here is to add, not to max(). It would be nice to have a test case with two floats that exercises this.

Adding is correct. A double pagination push can really only be triggered when the height of the pages is non-uniform, so really we're talking about a CSS regions edge case.

I added this test case so that the code is exercised and landed the patch in r96149.