Bug 68912
| Summary: | webkit-patch rebaseline-expectations ignores Chromium Linux GPU bot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrienne Walker <enne> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | enne, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrienne Walker
I was trying to rebaseline compositing/video-page-visibility.html. It was failing on Linux on the GPU path only.
Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=compositing%2Fvideo-page-visibility.html
Text expectations: http://trac.webkit.org/changeset/96088/trunk/LayoutTests/platform/chromium/test_expectations.txt
When I add REBASELINE to that expectation and run the script, it modifies text_expectations.txt but makes no other changes. It spits out this script output:
--SNIP--
enne@enne:/usr/local/google/home/enne/chrome/src/third_party/WebKit$ webkit-patch rebaseline-expectations
Retrieving results for chromium-cg-mac-leopard from Webkit Mac10.5 (CG).
Retrieving results for chromium-cg-mac-snowleopard from Webkit Mac10.6 (CG).
Retrieving results for chromium-gpu-cg-mac-leopard from Webkit Mac10.5 (CG) - GPU.
Retrieving results for chromium-gpu-cg-mac-snowleopard from Webkit Mac10.6 (CG) - GPU.
Retrieving results for chromium-gpu-win-win7 from Webkit Win7 - GPU.
Retrieving results for chromium-gpu-win-xp from Webkit Win - GPU.
Retrieving results for chromium-linux-x86 from Webkit Linux 32.
Retrieving results for chromium-linux-x86_64 from Webkit Linux.
Retrieving results for chromium-mac-leopard from Webkit Mac10.5.
Retrieving results for chromium-mac-snowleopard from Webkit Mac10.6.
Retrieving results for chromium-win-vista from Webkit Vista.
Retrieving results for chromium-win-win7 from Webkit Win7.
Retrieving results for chromium-win-xp from Webkit Win.
--SNIP--
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrienne Walker
"rebaseline-chromium-webkit-tests --use-deprecated-script" did the right thing with the same input.
Adam Barth
Thanks for the report. The problem is that these lines are commented out:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py#L61
We need to figure out how to uncomment them.
Adam Barth
*** Bug 66694 has been marked as a duplicate of this bug. ***