Bug 6889

Summary: SVG tetris does not work with WebKit+SVG
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.croczilla.com/svg/samples/svgtetris/svgtetris.svg
Attachments:
Description Flags
proposed patch.
none
better patch (fixes other invalidation issues)
none
patch to fix SVG Tetris. hyatt: review+

Eric Seidel (no email)
Reported 2006-01-28 05:12:01 PST
dynamic viewbox update does not work (breaks SVG tetris) http://www.croczilla.com/svg/samples/svgtetris/svgtetris.svg What's more important than SVG Tetris?
Attachments
proposed patch. (994 bytes, patch)
2006-01-28 05:27 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
better patch (fixes other invalidation issues) (4.00 KB, patch)
2006-01-28 05:51 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
patch to fix SVG Tetris. (4.59 KB, patch)
2006-01-28 06:39 PST, Eric Seidel (no email) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-01-28 05:27:33 PST
Created attachment 6046 [details] proposed patch.
Eric Seidel (no email)
Comment 2 2006-01-28 05:51:36 PST
Created attachment 6047 [details] better patch (fixes other invalidation issues) This also fixes the absolute transform reversal which we discovered earlier this week. This was necessary to make tetris actually invalidate the pieces as they drop correctly.
Eric Seidel (no email)
Comment 3 2006-01-28 06:39:37 PST
Created attachment 6048 [details] patch to fix SVG Tetris. Aw hell. I was close enough, I figured I'd just fix the whole darn SVG. There were 3 issues which I fixed here: 1. I fixed dynamic viewport updates (previously they were ignored). 2. I fixed absoluteTransform so that invalidation works (mostly... there still seems to be an issue or two). 3. I fixed MacFrame.mm to pass keydown correctly to nonhtml documents. The only part I can see anyone disagreeing with is #3 (perhaps the code should use documentElement() all the time instead of body()? There is also one small piece of my bug fix for CDF (from earlier this evening) shown in this patch.
Eric Seidel (no email)
Comment 4 2006-01-29 06:40:38 PST
Fixed in r12454.
Note You need to log in before you can comment on or make changes to this bug.