Bug 68874

Summary: Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, eric, justin.garcia, morrita, ojan, sullivan, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 68866, 68875, 68939, 69023, 69153    
Bug Blocks: 45784    
Attachments:
Description Flags
Patch
none
Patch none

Ryosuke Niwa
Reported 2011-09-27 00:23:51 PDT
As mentioned in several FIXMEs in ReplaceSelectionCommand, m_firstNodeInserted and m_lastLeafInserted should be replaced by real positions.
Attachments
Patch (21.24 KB, patch)
2011-09-30 14:32 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (21.26 KB, patch)
2011-09-30 14:34 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-09-30 14:32:36 PDT
Created attachment 109349 [details] Patch
Ryosuke Niwa
Comment 2 2011-09-30 14:34:41 PDT
Created attachment 109350 [details] Patch
WebKit Review Bot
Comment 3 2011-09-30 14:35:56 PDT
Attachment 109349 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:21: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 4 2011-09-30 14:36:01 PDT
Comment on attachment 109350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109350&action=review > Source/WebCore/editing/ReplaceSelectionCommand.cpp:1001 > + // Setup m_startOfInsertedContent and m_endOfInsertedContent. This should be the last two lines of code that access insertedNodes. We can do a follow up patch that puts the entire section that uses insertedNodes in a block to enforce this.
Ryosuke Niwa
Comment 5 2011-10-03 14:38:48 PDT
Any reviewers?
Enrica Casucci
Comment 6 2011-10-03 15:53:14 PDT
Comment on attachment 109350 [details] Patch Looks good to me.
Ryosuke Niwa
Comment 7 2011-10-03 16:04:35 PDT
Comment on attachment 109350 [details] Patch Clearing flags on attachment: 109350 Committed r96553: <http://trac.webkit.org/changeset/96553>
Ryosuke Niwa
Comment 8 2011-10-03 16:04:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.