Bug 68871

Summary: watchlist: Break out the diff boilerplate to allow for re-use.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68822, 68904    
Attachments:
Description Flags
Patch eric: review+, levin: commit-queue-

Description David Levin 2011-09-26 23:20:46 PDT
I would like to use a diff to be able to test the watchlist code by feeding it a diff and finding what definitions are matched.

I could create a new diff but it seems better just to re-use this one.
Comment 1 David Levin 2011-09-26 23:23:26 PDT
Created attachment 108792 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-26 23:27:23 PDT
Attachment 108792 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/common/checkout/diff_test_data.py:34:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/common/checkout/diff_test_data.py:39:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/common/checkout/diff_test_data.py:52:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/common/checkout/diff_test_data.py:60:  trailing whitespace  [pep8/W291] [5]
Tools/Scripts/webkitpy/common/checkout/diff_test_data.py:69:  trailing whitespace  [pep8/W291] [5]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2011-09-27 00:22:08 PDT
Comment on attachment 108792 [details]
Patch

Hm... OK.  We could also just store this as a .patch file in some new fixtures directory or similar.
Comment 4 David Levin 2011-09-27 08:37:33 PDT
(In reply to comment #3)
> (From update of attachment 108792 [details])
> Hm... OK.  We could also just store this as a .patch file in some new fixtures directory or similar.

I need to think about the form for just a little bit but I didn't want it to block my progress at the moment, so I added a FIXME and a bug: https://bugs.webkit.org/show_bug.cgi?id=68904

Committed as http://trac.webkit.org/changeset/96112