watchlist: Add parsing for definition section.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Levin]

See summary.

[David Levin]

Created attachment 108756 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 108756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108756&action=review

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:41
> +def _parse_definition_section(definition_section, watch_list):

You'll want these on an object, eventually.  Even if that object is a singleton. That way it's easier to mock later.

[Adam Barth]

Comment on attachment 108756 [details]
Patch

I think PEP8 requires all top-level definitions to have two blank lines between them.

[David Levin]

Committed as http://trac.webkit.org/changeset/96046

(In reply to comment #3)
> (From update of attachment 108756 [details])
> I think PEP8 requires all top-level definitions to have two blank lines between them.

Fixed for _eval_watch_list but not for the data structure definitions. fwiw PEP8 seems to not include them: "Separate top-level function and class definitions with two blank lines." and it would seem to introduce a lot of space to put in 2 blank lines around every top level data structure (dictionary, string, etc.)

(In reply to comment #2)
> (From update of attachment 108756 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108756&action=review
>
> You'll want these on an object, eventually.  Even if that object is a singleton. That way it's easier to mock later.

Ok, I'll consider that for the next patch. I have to think about this.