Bug 68841

Summary:

garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

New Bugs

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

66960

Attachments:

Description	Flags
Patch	abarth: review+, webkit.review.bot: commit-queue-

Dimitri Glazkov (Google)

Reported 2011-09-26 15:29:51 PDT

garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.

Attachments
Patch (6.00 KB, patch) 2011-09-26 15:31 PDT, Dimitri Glazkov (Google)	abarth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2011-09-26 15:31:01 PDT

Created attachment 108733 [details] Patch

WebKit Review Bot

Comment 2 2011-09-26 17:57:37 PDT

Comment on attachment 108733 [details] Patch Rejecting attachment 108733 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: c2996de174d922d6b506c8fb68458303b6422244 r96054 = 8ee031caadb0321203e774bc8560b9100ca4f84b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9883060

Dimitri Glazkov (Google)

Comment 3 2011-09-26 18:29:40 PDT

Comment on attachment 108733 [details] Patch Oh come on. It's good patch yes? Good patch!

WebKit Review Bot

Comment 4 2011-09-26 18:36:16 PDT

Comment on attachment 108733 [details] Patch Rejecting attachment 108733 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ns_unittests.js.rej patching file Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js Hunk #1 FAILED at 111. 1 out of 1 hunk FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9880108

Adam Barth

Comment 5 2011-10-02 10:19:00 PDT

I think dglazkov already landed this patch.

Note You need to log in before you can comment on or make changes to this bug.