Bug 6884

Summary: GC after destroying the very last frame to avoid node leak false positives
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: FramesAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
GC after destroying the very last Frame, from higher up on the stack ggaren: review+

Maciej Stachowiak
Reported 2006-01-27 17:43:35 PST
The NodeImpl leak counter can give false positives sometimes if the GC after destroying the last ScriptInterpreter doesn't collect everything due to stack references. Thus, in debug mode, it would be good to do a GC from Page's destructor after destroying the last frame, so we're at a point on the stack where there wont be JS object references.
Attachments
GC after destroying the very last Frame, from higher up on the stack (1.70 KB, patch)
2006-01-27 17:45 PST, Maciej Stachowiak 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-01-27 17:45:19 PST
Created attachment 6033 [details] GC after destroying the very last Frame, from higher up on the stack
Geoffrey Garen
Comment 2 2006-01-27 17:58:25 PST
Comment on attachment 6033 [details] GC after destroying the very last Frame, from higher up on the stack r=me I'm a little worried that we'll be finessing the garbage collector to avoid false leak reports in a lot more places. RenderObject comes to mind.
Note You need to log in before you can comment on or make changes to this bug.