Bug 68815

Summary: fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebCore Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dglazkov, sam, simon.fraser, varunjain
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Ryosuke Niwa 2011-09-26 10:49:36 PDT 
The following tests added by http://trac.webkit.org/changeset/95890 are failing on Mac WK1 port:
fast/dom/scroll-element-to-rect.html
fast/dom/scroll-element-to-rect-centered.html
Comment 1 Simon Fraser (smfr) 2011-09-28 16:49:03 PDT 
I think this is broken in WK1 because Element::boundsInWindowSpace() returns rect in flipped coordinates in WK1. "in window space" is not something that should be used in WebCore code much.
Comment 2 Simon Fraser (smfr) 2011-09-28 16:50:42 PDT 
Actually FrameView::scrollElementToRect() should not be using 'boundsInWindowSpace'. I think getRect() would work just fine.
Comment 3 Simon Fraser (smfr) 2011-09-28 17:14:20 PDT 
Created attachment 109099 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-09-28 17:44:39 PDT 
http://trac.webkit.org/changeset/96278
Comment 5 Varun Jain 2011-10-03 11:42:21 PDT 
(In reply to comment #4)
> http://trac.webkit.org/changeset/96278

Thanks Simon! for fixing this
Apologies for the delay as I could not get hold of a machine to repro the failure in time :(