Summary: | [mac] Timestamp parameter to requestAnimationFrame is busted in USE(REQUEST_ANIMATION_FRAME_TIMER) path | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cmarrin, dglazkov, nduca, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
James Robinson
2011-09-24 18:19:53 PDT
Created attachment 108595 [details]
Patch
Comment on attachment 108595 [details] Patch Attachment 108595 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9837495 New failing tests: fast/animation/request-animation-frame-timestamps-advance.html Created attachment 108601 [details]
test that passes in chromium DRT
Comment on attachment 108601 [details] test that passes in chromium DRT View in context: https://bugs.webkit.org/attachment.cgi?id=108601&action=review > LayoutTests/fast/animation/script-tests/request-animation-frame-timestamps-advance.js:24 > + if (window.layoutTestController) > + layoutTestController.display(); display() doesn't do anything for rAF in Safari/Mac. We need to figure out a way to make rAF tests that work in Safari and Chromium. Comment on attachment 108601 [details]
test that passes in chromium DRT
This test does pass in both, the .display()s trigger the rAF in chromium and yielding to the message loop triggers the rAF in Safari.
I think we should add a layoutTestController hook to trigger rAF callbacks, but it's a big pain in the butt to wire up layoutTestController additions to every build system so I haven't undertaken that task yet.
Comment on attachment 108601 [details] test that passes in chromium DRT Clearing flags on attachment: 108601 Committed r95937: <http://trac.webkit.org/changeset/95937> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > I think we should add a layoutTestController hook to trigger rAF callbacks, but it's a big pain in the butt to wire up layoutTestController additions to every build system so I haven't undertaken that task yet. Would adding the hook to window.internals make sense? I think yes - I was thinking of adding something to layoutTestController since that's where .display() is, but since this is supposed to exercise WebCore logic exclusively I guess window.internals would make sense. |