Bug 68702

Summary: Add OVERRIDE to overrides of virtual member functions in client classes
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Description Anders Carlsson 2011-09-23 10:11:11 PDT 
Add OVERRIDE to overrides of virtual member functions in client classes
Comment 1 Anders Carlsson 2011-09-23 10:13:39 PDT 
Created attachment 108487 [details]
Patch
Comment 2 Anders Carlsson 2011-09-23 10:35:19 PDT 
Looks like we need to disable the nonstandard warning on Windows.
Comment 3 WebKit Review Bot 2011-09-23 10:41:55 PDT 
Comment on attachment 108487 [details]
Patch

Attachment 108487 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9813311

New failing tests:
svg/custom/svg-fonts-word-spacing.html
Comment 4 Anders Carlsson 2011-09-23 10:42:07 PDT 
Created attachment 108491 [details]
Patch
Comment 5 Darin Adler 2011-09-23 10:49:23 PDT 
Comment on attachment 108491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108491&action=review

> Source/WebKit2/win/WebKit2Common.vsprops:13
> +		DisableSpecificWarnings="4481;4819"

Should explain in change log the relevance of disabling this warning.
Comment 6 Anders Carlsson 2011-09-23 11:06:30 PDT 
Committed r95834: <http://trac.webkit.org/changeset/95834>