Bug 68702

Summary: Add OVERRIDE to overrides of virtual member functions in client classes
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Anders Carlsson
Reported 2011-09-23 10:11:11 PDT
Add OVERRIDE to overrides of virtual member functions in client classes
Attachments
Patch (65.43 KB, patch)
2011-09-23 10:13 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (66.03 KB, patch)
2011-09-23 10:42 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-09-23 10:13:39 PDT
Created attachment 108487 [details] Patch
Anders Carlsson
Comment 2 2011-09-23 10:35:19 PDT
Looks like we need to disable the nonstandard warning on Windows.
WebKit Review Bot
Comment 3 2011-09-23 10:41:55 PDT
Comment on attachment 108487 [details] Patch Attachment 108487 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9813311 New failing tests: svg/custom/svg-fonts-word-spacing.html
Anders Carlsson
Comment 4 2011-09-23 10:42:07 PDT
Created attachment 108491 [details] Patch
Darin Adler
Comment 5 2011-09-23 10:49:23 PDT
Comment on attachment 108491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108491&action=review > Source/WebKit2/win/WebKit2Common.vsprops:13 > + DisableSpecificWarnings="4481;4819" Should explain in change log the relevance of disabling this warning.
Anders Carlsson
Comment 6 2011-09-23 11:06:30 PDT
Committed r95834: <http://trac.webkit.org/changeset/95834>
Note You need to log in before you can comment on or make changes to this bug.