REGRESSION: JavaScript Date constructor won't accept another Date object

• Component: JavaScriptCore
• Status: VERIFIED FIXED

Go to www.qantas.com.au.  Click on the tab labelled "International" and you'll find you can't select departure dates at all.

[Joost de Valk (AlthA)]

Confirmed, this one needs reduction.

[David Kilzer (:ddkilzer)]

This is a regression.  Works for me in Safari 2.0.3 (417.8) on 10.4.4.

[Joost de Valk (AlthA)]

If it's a regression, it should be P1 :)

[David Kilzer (:ddkilzer)]

This is broken in WebKit-CVS-2005-10-01 03-27-01 GMT.dmg, the very first nightly build available.

It broke between the time WebKit was open-sourced and the date on the above nightly.

[David Kilzer (:ddkilzer)]

Created attachment 6035 [details]
Test case v1

[David Kilzer (:ddkilzer)]

The Date object in JavaScript won't accept another Date object in a single-argument constructor:

  var d = new Date(new Date());  // Results in "Invalid Date" 

Works correctly in Firefox 1.5 and Safari 2.0.3 (417.8) on 10.4.4.

[Darin Adler]

I've got a fix. The Date constructor was not following the algorithm from the JavaScript specification properly. It was supposed to convert to a primitive, then check to see if the result is a string. Instead it was checking to see if the result was a string first.

[Darin Adler]

Created attachment 6060 [details]
patch to fix bug, including a test

[David Kilzer (:ddkilzer)]

Verified fix.

[Eric Seidel (no email)]

Removing Regression keyword from bugs already fixed.

[David Kilzer (:ddkilzer)]

Added back removed keywords.