Bug 68696

Summary: [Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: New BugsAssignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68962    
Attachments:
Description Flags
Patch none

Jesus Sanchez-Palencia
Reported 2011-09-23 07:42:20 PDT
[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
Attachments
Patch (3.85 KB, patch)
2011-09-23 07:50 PDT, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2011-09-23 07:50:06 PDT
Created attachment 108473 [details] Patch
Andreas Kling
Comment 2 2011-09-23 07:53:55 PDT
Comment on attachment 108473 [details] Patch r=me
Jesus Sanchez-Palencia
Comment 3 2011-09-23 08:05:41 PDT
Comment on attachment 108473 [details] Patch Clearing flags on attachment: 108473 Committed r95804: <http://trac.webkit.org/changeset/95804>
Jesus Sanchez-Palencia
Comment 4 2011-09-23 08:05:48 PDT
All reviewed patches have been landed. Closing bug.
Jesus Sanchez-Palencia
Comment 5 2011-09-23 08:12:23 PDT
Just clarifying this fix a bit: The Download object was holding a NULL pointer to QtFileDownloader because QtFileDownloader ctor was starting everything by calling onReadyRead(). So even before the return of the ctor QtFileDownloader was calling functions from Download that were trying to call back functions from a null QtFileDownloader, crashing WebProcess. Now we call the ctor and then QtFileDownloader::start().
Note You need to log in before you can comment on or make changes to this bug.