Bug 68654

Summary:

We should add support for OVERRIDE and FINAL annotations

Product:

WebKit

Reporter:

James Robinson <jamesr>

Component:

Tools / Tests

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin, jamesr, thakis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

69904

Attachments:

Description	Flags
Patch	none
Patch	hyatt: review+

Description James Robinson 2011-09-22 13:45:18 PDT

These C++11 annotations are useful for detecting programming errors.  We've gained a lot of utility from these in the Chromium repo, and I've locally written plenty of bugs that these would catch.

MSVS2005, recent clangs, and GCC 4.7+ support these annotations.  We should be able to define these annotations as no-ops on other compilers and still get broad coverage from developers and across the buildbots.

Comment 1 Anders Carlsson 2011-09-22 13:55:42 PDT

Created attachment 108396 [details]
Patch

Comment 2 Anders Carlsson 2011-09-22 14:08:48 PDT

Created attachment 108400 [details]
Patch

Comment 3 Dave Hyatt 2011-09-22 15:31:37 PDT

Comment on attachment 108400 [details]
Patch

r=me

Comment 4 Darin Adler 2011-09-22 16:08:10 PDT

Can’t wait!

Comment 5 Anders Carlsson 2011-09-23 09:48:05 PDT

Committed r95823: <http://trac.webkit.org/changeset/95823>