Bug 68650

Summary: [CSSRegions] Make determineStartPosition stop when it hits a line that moved to a new region
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Dave Hyatt 2011-09-22 12:59:42 PDT 
determineStartPosition will skip over non-dirty lines that have ended up in new regions with different available content widths. We need to check for this case and treat the line as dirty instead.
Comment 1 Dave Hyatt 2011-09-22 13:07:52 PDT 
Created attachment 108386 [details]
Patch
Comment 2 Sam Weinig 2011-09-22 13:30:58 PDT 
Comment on attachment 108386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108386&action=review

> Source/WebCore/rendering/RenderBlock.cpp:6352
> +bool RenderBlock::lineWidthForPaginatedLineChanged(RootInlineBox* rootBox) const

This should probably have a small comment in the header explaining its use.
Comment 3 Dave Hyatt 2011-09-22 13:49:47 PDT 
Fixed in r95750.
Comment 4 Adam Roben (:aroben) 2011-09-22 13:51:48 PDT 
Comment on attachment 108386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108386&action=review

> Source/WebCore/ChangeLog:7
> +        region with a different available content logical width. When this happens, we go ahead and treat
> +        the line as dirty.

You played right into Sam's hands with that one.