Bug 68650

Summary: [CSSRegions] Make determineStartPosition stop when it hits a line that moved to a new region
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dave Hyatt
Reported 2011-09-22 12:59:42 PDT
determineStartPosition will skip over non-dirty lines that have ended up in new regions with different available content widths. We need to check for this case and treat the line as dirty instead.
Attachments
Patch (150.91 KB, patch)
2011-09-22 13:07 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-09-22 13:07:52 PDT
Created attachment 108386 [details] Patch
Sam Weinig
Comment 2 2011-09-22 13:30:58 PDT
Comment on attachment 108386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108386&action=review > Source/WebCore/rendering/RenderBlock.cpp:6352 > +bool RenderBlock::lineWidthForPaginatedLineChanged(RootInlineBox* rootBox) const This should probably have a small comment in the header explaining its use.
Dave Hyatt
Comment 3 2011-09-22 13:49:47 PDT
Fixed in r95750.
Adam Roben (:aroben)
Comment 4 2011-09-22 13:51:48 PDT
Comment on attachment 108386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108386&action=review > Source/WebCore/ChangeLog:7 > + region with a different available content logical width. When this happens, we go ahead and treat > + the line as dirty. You played right into Sam's hands with that one.
Note You need to log in before you can comment on or make changes to this bug.