Bug 68627

Summary: Web Inspector: Clicking on error doesn't point on the correct line if user searched something
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dpetroff, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Vsevolod Vlasov 2011-09-22 09:13:52 PDT 
Original report: http://code.google.com/p/chromium/issues/detail?id=92883

1)Open the page with some error in scripts.
2)Open scripts pane and enter some letters to allow webinspector to find few lines.
3)Don't reset search, open console pane and try to locate error by clicking on the message.

As result, web inspector will open scripts pane but will focus on the search result not the error.
Comment 1 Vsevolod Vlasov 2011-09-22 09:20:41 PDT 
Created attachment 108345 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-23 08:10:13 PDT 
Comment on attachment 108345 [details]
Patch

Rejecting attachment 108345 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ch : (1)
  svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE


Exception in thread QueueFeederThread (most likely raised during interpreter shutdown):
Full output: http://queues.webkit.org/results/9818136
Comment 3 WebKit Review Bot 2011-09-23 08:56:20 PDT 
Comment on attachment 108345 [details]
Patch

Clearing flags on attachment: 108345

Committed r95807: <http://trac.webkit.org/changeset/95807>
Comment 4 WebKit Review Bot 2011-09-23 08:56:25 PDT 
All reviewed patches have been landed.  Closing bug.