Bug 68623

Summary: run-safari doesn't work if there are spaces in the path to %WEBKITOUTPUTDIR%
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: sfalken
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Use the "direct object" form of system() to run WebKit.exe sfalken: review+

Adam Roben (:aroben)
Reported 2011-09-22 08:52:06 PDT
To reproduce: 1. Set %WEBKITOUTPUTDIR% to something with spaces in it 2. build-webkit 3. run-safari run-safari fails with an error message like this: Can't exec "/home/Adam": No such file or directory at /home/Adam Roben/dev/WebKit/OpenSource/Tools/Scripts/webkitdirs.pm line 2031.
Attachments
Use the "direct object" form of system() to run WebKit.exe (1.64 KB, patch)
2011-09-22 08:56 PDT, Adam Roben (:aroben) 		sfalken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-09-22 08:56:59 PDT
Created attachment 108341 [details] Use the "direct object" form of system() to run WebKit.exe
Adam Roben (:aroben)
Comment 2 2011-09-22 10:51:44 PDT
Committed r95732: <http://trac.webkit.org/changeset/95732>
Note You need to log in before you can comment on or make changes to this bug.