Bug 68595 – [EFL] Add matrix list to reuse tile matrix for each different zoom level.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[KwangHyuk]

Matrix list keeps each tiled matrix for different zoom level when zoom level is changed.
And then it will resue the tile matrix previously created by getting it from this matrix list.

[KwangHyuk]

Created attachment 108284 [details]
Patch.

[WebKit Review Bot]

Comment on attachment 108284 [details]
Patch.

Attachment 108284 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9797123

New failing tests:
svg/custom/svg-fonts-word-spacing.html

[KwangHyuk]

Created attachment 108321 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 108321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108321&action=review

The idea sounds good, but the implementation needs some love. As we're trying to adequate ourselves to WebKit's coding style, it would be really good if these one or two-letter variables had proper names. There are many separate places which allocate and remove entries from the list, this code should all be put in single functions.

> Source/WebKit/efl/ChangeLog:7
> +        And then it will resue the tile matrix previously created by getting it from this matrix list.

resue -> reuse

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.c:119
> +        Eina_Bool layout:1;

Isn't it possible to use change.model here?

> Source/WebKit/efl/ewk/ewk_tiled_matrix.c:72
> +Ewk_Tile_Matrix_Entry *ewk_tile_matrix_matrix_from_zoom_get(Ewk_Tile_Matrix *tm, float zoom);

The implementation can be moved here and the function can be made static. "from_zoom" doesn't sound good in the name. Maybe just _ewk_tile_matrix_matrix_get, or _ewk_tile_matrix_get?

> Source/WebKit/efl/ewk/ewk_tiled_matrix.h:33
> +void ewk_tile_matrix_change_matrix(Ewk_Tile_Matrix* tm, float zoom);

This name doesn't tell what the function is supposed to do. How about ewk_tile_matrix_zoom_level_set() or something along these lines?

[KwangHyuk]

> The idea sounds good, but the implementation needs some love. As we're trying  to adequate ourselves to WebKit's coding style, it would be really good if > these one or two-letter variables had proper names. There are many separate places which allocate and remove entries from the list, this code should all be put in single functions.

Ok, let me check. :-)

>> Source/WebKit/efl/ChangeLog:7
>> +        And then it will resue the tile matrix previously created by getting it from this matrix list.
>
> resue -> reuse

Ok, thank you for your correction.

>> Source/WebKit/efl/ewk/ewk_tiled_backing_store.c:119
>> +        Eina_Bool layout:1;
>
> Isn't it possible to use change.model here?

Good point.

>> Source/WebKit/efl/ewk/ewk_tiled_matrix.c:72
>> +Ewk_Tile_Matrix_Entry *ewk_tile_matrix_matrix_from_zoom_get(Ewk_Tile_Matrix *tm, float zoom);
>
> The implementation can be moved here and the function can be made static. "from_zoom" doesn't sound good in the name. Maybe just _ewk_tile_matrix_matrix_get, or _ewk_tile_matrix_get?

Make sense.

>> Source/WebKit/efl/ewk/ewk_tiled_matrix.h:33
>> +void ewk_tile_matrix_change_matrix(Ewk_Tile_Matrix* tm, float zoom);
>
> This name doesn't tell what the function is supposed to do. How about ewk_tile_matrix_zoom_level_set() or something along these lines?

Ok, I will try it. :-)

[KwangHyuk]

Created attachment 111121 [details]
Patch.

> The idea sounds good, but the implementation needs some love. As we're trying  to adequate ourselves to WebKit's coding style, it would be really good if > these one or two-letter variables had proper names. There are many separate places which allocate and remove entries from the list, this code should all be put in single functions.

The most of your opinions are applied.

>> Source/WebKit/efl/ChangeLog:7
>> +        And then it will resue the tile matrix previously created by getting it from this matrix list.
>
> resue -> reuse

Applied.

>> Source/WebKit/efl/ewk/ewk_tiled_backing_store.c:119
>> +        Eina_Bool layout:1;
>
> Isn't it possible to use change.model here?

Applied.

>> Source/WebKit/efl/ewk/ewk_tiled_matrix.c:72
>> +Ewk_Tile_Matrix_Entry *ewk_tile_matrix_matrix_from_zoom_get(Ewk_Tile_Matrix *tm, float zoom);
>
> The implementation can be moved here and the function can be made static. "from_zoom" doesn't sound good in the name. Maybe just _ewk_tile_matrix_matrix_get, or _ewk_tile_matrix_get?

Applied.

>> Source/WebKit/efl/ewk/ewk_tiled_matrix.h:33
>> +void ewk_tile_matrix_change_matrix(Ewk_Tile_Matrix* tm, float zoom);
>
> This name doesn't tell what the function is supposed to do. How about ewk_tile_matrix_zoom_level_set() or something along these lines?

Applied.

[KwangHyuk]

Created attachment 111122 [details]
Patch.

[KwangHyuk]

Created attachment 111135 [details]
Patch.

[Gyuyoung Kim]

Comment on attachment 111135 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=111135&action=review

> Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:283
> +

Unneeded Line.

> Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:284
> +

ditto.

[KwangHyuk]

Created attachment 111200 [details]
Patch.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 111200 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=111200&action=review

It looks much better now. This part of the code is not my area of expertise, but if it works, then I'm OK with it after you fix these small nitpicks below.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1493
> +

Extra empty line.

> Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:186
> + * @param currentZoom current zoom level for the matrix.

"zoomLevel" makes more sense here.

[KwangHyuk]

Created attachment 111359 [details]
Patch.

[Raphael Kubo da Costa (:rakuco)]

LGTM.

[Gyuyoung Kim]

Comment on attachment 111359 [details]
Patch.

LGTM too.

[KwangHyuk]

Created attachment 114618 [details]
patch rebased.

[KwangHyuk]

Created attachment 115535 [details]
Patch rebased.

[Kenneth Rohde Christiansen]

Comment on attachment 115535 [details]
Patch rebased.

rs=me given the informal reviews and as this is very EFL only

[WebKit Review Bot]

Comment on attachment 115535 [details]
Patch rebased.

Rejecting attachment 115535 [details] from commit-queue.

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
Full output: http://queues.webkit.org/results/10461130

[KwangHyuk]

Created attachment 115709 [details]
Patch rebased.

[Gyuyoung Kim]

Comment on attachment 115709 [details]
Patch rebased.

LGTM too.

[WebKit Review Bot]

Comment on attachment 115709 [details]
Patch rebased.

Clearing flags on attachment: 115709

Committed r100724: <http://trac.webkit.org/changeset/100724>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.