Bug 68541

Summary:

Web Inspector: UI performance test for Scripts panel first open experience.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[patch] initial version	pfeldman: review-
[patch] initial version	none
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2011-09-21 09:36:01 PDT

%subj%

Attachments
[patch] initial version (18.32 KB, patch) 2011-09-21 09:38 PDT, Ilya Tikhonovsky	pfeldman: review-	Details Formatted Diff Diff
[patch] initial version (2.19 KB, patch) 2011-09-22 07:14 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (2.33 KB, patch) 2011-09-23 02:43 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2011-09-21 09:38:20 PDT

Created attachment 108170 [details] [patch] initial version

Pavel Feldman

Comment 2 2011-09-22 05:13:01 PDT

Comment on attachment 108170 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=108170&action=review > LayoutTests/http/tests/inspector/inspector-test.js:11 > +//console.log = consoleOutputHook.bind(InspectorTest, "log"); Why did this change? > LayoutTests/inspector/performance/resources/first-open-scripts.html:38 > +var initialize_InspectorTest = function() { Could you extract a javascript file with the test data?

Ilya Tikhonovsky

Comment 3 2011-09-22 07:14:47 PDT

Created attachment 108328 [details] [patch] initial version

Yury Semikhatsky

Comment 4 2011-09-23 00:31:50 PDT

Yury Semikhatsky

Comment 5 2011-09-23 02:35:20 PDT

Comment on attachment 108328 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=108328&action=review > LayoutTests/inspector/performance/resources/first-open-scripts.html:30 > + setTimeout = originalSetTimeout; Instead of overriding setTimeout which changes regular execution sequence we should find an event that is fired definitely after the panel switch has completed. If there is no such event at the moment we could expose corresponding method on the panel for the test. Any of these seems better than overriding setTimeout

Ilya Tikhonovsky

Comment 6 2011-09-23 02:43:08 PDT

Created attachment 108451 [details] Patch

Yury Semikhatsky

Comment 7 2011-09-23 03:06:20 PDT

Comment on attachment 108451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108451&action=review > LayoutTests/inspector/performance/resources/first-open-scripts.html:28 > + WebInspector.panels.scripts._visibleView._textViewer._mainPanel._paintScheduledLines(); Extract WebInspector.panels.scripts._visibleView._textViewer._mainPanel into a local variable?

Ilya Tikhonovsky

Comment 8 2011-09-23 03:59:14 PDT

Committed r95792: <http://trac.webkit.org/changeset/95792>

Note You need to log in before you can comment on or make changes to this bug.