Bug 68368

Summary: [chromium] Gesture recognizer fires taptype only every other touch down/up sequence
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: UI EventsAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rjkroege, varunjain, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Robert Kroeger 2011-09-19 10:02:15 PDT 
The chromium gesture recognizer has a bug where only every other touch down/touch up sequence generates a tapdown/tap PlatformGestureEvent sequence. This is wrong.
Comment 1 Robert Kroeger 2011-09-19 10:08:31 PDT 
Created attachment 107876 [details]
Patch
Comment 2 Robert Kroeger 2011-09-19 10:12:38 PDT 
Hi Adam,

Could you have at this small bug fix for the GestureRecognizer please?

Thanks.
Comment 3 Adam Barth 2011-09-19 11:01:02 PDT 
Comment on attachment 107876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107876&action=review

> Source/WebCore/ChangeLog:9
> +        outgoing edges in the recognizer state machine. Thsi change simplifies the logic

Thsi => This

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:39
> +static const double maximumSecondsBetweenDoubleClick = .7;

Maybe use a leading 0 to be consistent with the declarations above?
Comment 4 Robert Kroeger 2011-09-19 11:11:55 PDT 
I can fix this. New patch attached rsn.
Comment 5 Robert Kroeger 2011-09-19 11:14:02 PDT 
Created attachment 107891 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-19 12:12:10 PDT 
Comment on attachment 107891 [details]
Patch

Clearing flags on attachment: 107891

Committed r95452: <http://trac.webkit.org/changeset/95452>
Comment 7 WebKit Review Bot 2011-09-19 12:12:14 PDT 
All reviewed patches have been landed.  Closing bug.