Bug 68368

Summary: [chromium] Gesture recognizer fires taptype only every other touch down/up sequence
Product: WebKit Reporter: Robert Kroeger <rjkroege>
Component: UI EventsAssignee: Robert Kroeger <rjkroege>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rjkroege, varunjain, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robert Kroeger
Reported 2011-09-19 10:02:15 PDT
The chromium gesture recognizer has a bug where only every other touch down/touch up sequence generates a tapdown/tap PlatformGestureEvent sequence. This is wrong.
Attachments
Patch (16.71 KB, patch)
2011-09-19 10:08 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Patch (16.71 KB, patch)
2011-09-19 11:14 PDT, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2011-09-19 10:08:31 PDT
Created attachment 107876 [details] Patch
Robert Kroeger
Comment 2 2011-09-19 10:12:38 PDT
Hi Adam, Could you have at this small bug fix for the GestureRecognizer please? Thanks.
Adam Barth
Comment 3 2011-09-19 11:01:02 PDT
Comment on attachment 107876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107876&action=review > Source/WebCore/ChangeLog:9 > + outgoing edges in the recognizer state machine. Thsi change simplifies the logic Thsi => This > Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:39 > +static const double maximumSecondsBetweenDoubleClick = .7; Maybe use a leading 0 to be consistent with the declarations above?
Robert Kroeger
Comment 4 2011-09-19 11:11:55 PDT
I can fix this. New patch attached rsn.
Robert Kroeger
Comment 5 2011-09-19 11:14:02 PDT
Created attachment 107891 [details] Patch
WebKit Review Bot
Comment 6 2011-09-19 12:12:10 PDT
Comment on attachment 107891 [details] Patch Clearing flags on attachment: 107891 Committed r95452: <http://trac.webkit.org/changeset/95452>
WebKit Review Bot
Comment 7 2011-09-19 12:12:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.