Bug 68331
| Summary: | [chromium] frameContentAsPlainText shouldn't be using TextIterator | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | morrita, schenney, sullivan, tkent, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 68333 | ||
Ryosuke Niwa
We should avoid using TextIterator directly in WebKit layer code. Justification for not using plainText is that:
" // The text iterator will walk nodes giving us text. This is similar to
// the plainText() function in TextIterator.h, but we implement the maximum
// size and also copy the results directly into a wstring, avoiding the
// string conversion."
However, this comment is not true at all as the function currently takes Vector<UChar>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Stephen Chenney
https://code.google.com/p/chromium/issues/detail?id=230629