Summary: | method_check should repatch itself if it finds that the new structure(s) are the result of transitions from the old structure(s) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, fpizlo, ggaren, oliver, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2011-09-16 17:11:43 PDT
Created attachment 107749 [details]
the patch
Attachment 107749 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:1634: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:1644: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:1645: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/jit/JITStubs.cpp:1646: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 107751 [details]
the patch
|