[GTK] Linker error with double inclusion of ScrollbarThemeMock.cpp

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Wajahat Siddiqui]

Gtk build is broken on svn rev# 95275 as ScrollbarThemeMock.cpp is mistakenly included twice in Source/WebCore/GNUmakefile.list.am. 
This is added from attachment committed from https://bugs.webkit.org/show_bug.cgi?id=68134
--- a/Source/WebCore/GNUmakefile.list.am
+++ b/Source/WebCore/GNUmakefile.list.am
@@ -2686,6 +2686,8 @@ webcore_sources += \
 	Source/WebCore/platform/mock/GeolocationClientMock.h \
 	Source/WebCore/platform/mock/GeolocationServiceMock.cpp \
 	Source/WebCore/platform/mock/GeolocationServiceMock.h \
+	Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \
+	Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \
 	Source/WebCore/platform/mock/SpeechInputClientMock.cpp \
 	Source/WebCore/platform/mock/SpeechInputClientMock.h \
 	Source/WebCore/platform/network/AuthenticationChallengeBase.cpp \

Attached patch corrects this issue

[Wajahat Siddiqui]

Created attachment 107619 [details]
linker error fix

fixing this issue by removing double inclusion.

[Wajahat Siddiqui]

Created attachment 107620 [details]
linker error fix updated changelog

updating changelog

[Alejandro G. Castro]

Comment on attachment 107620 [details]
linker error fix updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=107620&action=review

Thanks for the patch but I've already fixed the issue http://trac.webkit.org/changeset/95280, this kind of patches do not need review. Could you remove the r? tag?

> Source/WebCore/GNUmakefile.list.am:-2688
> -	Source/WebCore/platform/mock/ScrollbarThemeMock.cpp \

I think we do not have to remove the line but change .cpp for .h.

[Wajahat Siddiqui]

fixed in http://trac.webkit.org/changeset/95280

[Wajahat Siddiqui]

fixed in http://trac.webkit.org/changeset/95280

[Simon Fraser (smfr)]

Thanks for fixing!