| Summary: | [EFL] Bump minimum requirement for cairo to 1.10. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, paroga, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2011-09-15 23:54:17 PDT
Below are error message. [ 8%] [ 8%] [ 8%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/CairoUtilities.cpp.o Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/FontCairo.cpp.o Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/GraphicsContextCairo.cpp.o [ 8%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/ImageBufferCairo.cpp.o In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:28: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:84: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:84: error: expected ‘,’ or ‘...’ before ‘*’ token /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: In function ‘void WebCore::appendRegionToCairoContext(cairo_t*, int)’: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:86: error: ‘region’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:89: error: ‘region’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:89: error: ‘cairo_region_num_rectangles’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:91: error: aggregate ‘cairo_rectangle_int_t rect’ has incomplete type and cannot be defined /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:92: error: ‘cairo_region_get_rectangle’ was not declared in this scope make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/CairoUtilities.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:38: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/FontCairo.cpp:34: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:34: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/ImageBufferCairo.cpp.o] Error 1 make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/GraphicsContextCairo.cpp.o] Error 1 make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/FontCairo.cpp.o] Error 1 Created attachment 107612 [details]
Patch
LGTM. Comment on attachment 107612 [details] Patch Clearing flags on attachment: 107612 Committed r95379: <http://trac.webkit.org/changeset/95379> All reviewed patches have been landed. Closing bug. |