Summary: | remove redundant and error-prone semantics with m_dirtyRect and m_contentsDirty in LayerChromium. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Singh <shawnsingh> | ||||||
Component: | Layout and Rendering | Assignee: | Shawn Singh <shawnsingh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enne, jamesr, nduca, piman, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Shawn Singh
2011-09-15 19:36:48 PDT
Created attachment 107595 [details]
Patch
Comment on attachment 107595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107595&action=review > Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:72 > + if (!m_dirtyRect.isEmpty()) { Since you're here, this if check is clearly unnecessary. Can you remove it? Created attachment 107669 [details]
Patch
Comment on attachment 107669 [details]
Patch
Cool
Comment on attachment 107669 [details] Patch Clearing flags on attachment: 107669 Committed r95365: <http://trac.webkit.org/changeset/95365> All reviewed patches have been landed. Closing bug. |