Bug 68211

Summary: remove default NULL argument in LayerChromium::create()
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, nduca, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2011-09-15 19:29:59 PDT
All existing instances of LayerChromium give an instance of the delegate, and it seems error prone to keep this default arg.
Attachments
Patch (1.34 KB, patch)
2011-09-15 19:58 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2011-09-15 19:58:02 PDT
Created attachment 107588 [details] Patch
James Robinson
Comment 2 2011-09-15 23:47:45 PDT
Comment on attachment 107588 [details] Patch Looks good. PluginLayerChromium has one of these too
WebKit Review Bot
Comment 3 2011-09-16 17:49:33 PDT
Comment on attachment 107588 [details] Patch Clearing flags on attachment: 107588 Committed r95344: <http://trac.webkit.org/changeset/95344>
WebKit Review Bot
Comment 4 2011-09-16 17:49:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.