Bug 68185
Summary: | Multiple form submission bit is being cleared at the wrong abstraction layer | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> |
Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | aestes, ap, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 37236, 39021 |
Jon Lee
From bug 28633.
resetMultipleFormSubmissionProtection() is being called in EventHandler's keyEvent() and handleMousePressEvent() functions, and should be moved to another abstraction layer.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/10132369>
Alexey Proskuryakov
One question is why we still have multiple form submission protection code at all. It's explicitly turned off for user actions, and it ineffective in some other cases (see bug 13011). At the same time, there are many closely related bugs tracked under bug 39021 umbrella, suggesting that the logic is fundamentally different from other browsers.