Bug 6818

Summary: garbage collect a bit later when destroying Frame (fixes node leak false positives)
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: FramesAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
skip the clear, GC after destroying ScriptInterpreter hyatt: review+

Maciej Stachowiak
Reported 2006-01-25 20:59:01 PST
Frame clears the properties of the window object and garbage collects every time you change documents. This is good, because you don't want to leak custom properties to the next document, and because much garbage will be created when the properties are cleared. However, it also does this on destruction. That's suboptimal, because the window object itself (and everything it keeps alive) will become collectable after the ScriptInterpreter is destroyed. So the clearing is a waste of time, and the garbage collection would be better done later. On top of all that, this causes false positives from the NodeImpl leak counter.
Attachments
skip the clear, GC after destroying ScriptInterpreter (2.68 KB, patch)
2006-01-25 21:03 PST, Maciej Stachowiak 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-01-25 21:03:23 PST
Created attachment 5969 [details] skip the clear, GC after destroying ScriptInterpreter
Dave Hyatt
Comment 2 2006-01-25 21:07:31 PST
Comment on attachment 5969 [details] skip the clear, GC after destroying ScriptInterpreter r=me but run the PLT and layout tests.
Note You need to log in before you can comment on or make changes to this bug.