Bug 6816

Summary:

Crash in dispatchMouseEvent - Missing nil check

Product:

WebKit

Reporter:

Adele Peterson <adele>

Component:

New Bugs

Assignee:

Adele Peterson <adele>

Status:

RESOLVED FIXED

Severity:

Major

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	mjs: review+

Adele Peterson

Reported 2006-01-25 20:12:41 PST

Date/Time: 2006-01-25 20:04:22.271 -0800 OS Version: 10.4.4 (Build 8G32) Report Version: 3 Command: Safari Path: /Build/symroots/Development/Safari.app/Contents/MacOS/Safari Parent: bash [19431] Version: 2.0.1 (420+) Build Version: 1 Project Name: WebBrowser Source Version: 4161300 PID: 22324 Thread: 0 Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000018 Thread 0 Crashed: 0 com.apple.WebCore 0x020b7a6c WebCore::NodeImpl::renderer() const + 20 (NodeImpl.h:336) 1 com.apple.WebCore 0x01f00248 FrameView::dispatchMouseEvent(WebCore::AtomicString const&, WebCore::NodeImpl*, bool, int, QMouseEvent*, bool, int) + 1204 (FrameView.cpp:1089) 2 com.apple.WebCore 0x01f010dc FrameView::viewportMousePressEvent(QMouseEvent*) + 644 (FrameView.cpp:544) 3 com.apple.WebCore 0x01ef3b08 MacFrame::mouseDown(NSEvent*) + 732 (MacFrame.mm:2085) 4 com.apple.WebCore 0x01f280b8 -[WebCoreFrameBridge mouseDown:] + 52 (WebCoreFrameBridge.mm:1106) 5 com.apple.WebKit 0x0127dc38 -[WebHTMLView mouseDown:] + 492 (WebHTMLView.m:2653) 6 com.apple.AppKit 0x936d5eb0 -[NSWindow sendEvent:] + 4616 7 com.apple.Safari 0x00100200 -[Window sendEvent:] + 320 (Window.m:76) 8 com.apple.AppKit 0x9367eef4 -[NSApplication sendEvent:] + 4172 9 com.apple.Safari 0x00030910 -[BrowserApplication sendEvent:] + 736 (BrowserApplication.m:139) 10 com.apple.AppKit 0x93676330 -[NSApplication run] + 508 11 com.apple.AppKit 0x93766e68 NSApplicationMain + 452 12 com.apple.Safari 0x000f8c3c main + 160 (main.m:23) 13 com.apple.Safari 0x00002510 _start + 340 (crt.c:272) 14 com.apple.Safari 0x000023b8 start + 60

Attachments
patch (1.22 KB, patch) 2006-01-25 20:17 PST, Adele Peterson	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adele Peterson

Comment 1 2006-01-25 20:14:13 PST

I'm not entirely sure how to reproduce this, but it was caused by my recent change to support the new text fields. I have a fix...

Adele Peterson

Comment 2 2006-01-25 20:17:52 PST

Created attachment 5968 [details] patch

Maciej Stachowiak

Comment 3 2006-01-25 20:30:43 PST

Comment on attachment 5968 [details] patch You could consider using ?: syntax instead if if() to do the conditional initialization. But fine to commit either way.

Note You need to log in before you can comment on or make changes to this bug.