Bug 68111

Summary: Address lifetime issues in OfflineAudioDestinationNode (take 2)
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Chris Rogers
Reported 2011-09-14 13:25:37 PDT
Address Address lifetime issues in OfflineAudioDestinationNode (take 2)
Attachments
Patch (2.11 KB, patch)
2011-09-14 13:27 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2011-09-14 13:43 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-09-14 13:27:32 PDT
Created attachment 107384 [details] Patch
Chris Rogers
Comment 2 2011-09-14 13:31:42 PDT
my previous patch was incorrect: http://trac.webkit.org/changeset/94984 It's too late to call waitForThreadCompletion() in the destructor, since there's could still be a pending callOnMainThread() using this object. The object must stay alive longer. The approach taken with this new patch is to take a reference just before the worker thread is created, then release the reference once the callOnMainThread() handler has finished. Then we can avoid calling waitForThreadCompletion()
Chris Rogers
Comment 3 2011-09-14 13:43:59 PDT
Created attachment 107388 [details] Patch
Kenneth Russell
Comment 4 2011-09-14 14:20:30 PDT
Comment on attachment 107388 [details] Patch Looks good to me.
Chris Rogers
Comment 5 2011-09-14 14:38:37 PDT
Committed r95124: <http://trac.webkit.org/changeset/95124>
Note You need to log in before you can comment on or make changes to this bug.