Bug 68055 – [WEBKIT2] WebKitWebFrame WebKit1 style API implementation

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Nayan Kumar K]

Add WebKitWebFrame WebKit1 style GTK API

[Nayan Kumar K]

Created attachment 107285 [details]
WebKitWebFrame WebKit1 style API

Draft patch illustrating the WebKitWebFrame WebKit1 style API implementation.

I had to make changes in platform dependent code (LoaderClient) to know when a mainFrame is created (Similar changes might have to be done for sub frame creation as well). Right now this patch just implements didCreateMainFrame and creates WebKitWebFrame main frame object once this callback gets called.

[Gustavo Noronha (kov)]

Comment on attachment 107285 [details]
WebKitWebFrame WebKit1 style API

Attachment 107285 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9657402

[Nayan Kumar K]

Created attachment 107298 [details]
WebKitWebFrame WebKit1 style API implementation

Oops.. Missed git add'ing newly created files in earlier patch.

[WebKit Review Bot]

Attachment 107298 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/gtk/WebKitWebFrame.h:47:  parent_instance is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebFrame.h:54:  parent_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebFrame.cpp:43:  webkit_web_frame_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebFrame.cpp:49:  webkit_web_frame_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebFrame.cpp:77:  webkit_web_frame_get_web_view is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 5 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Please don't put [GTK] in summary when a patch touches cross-platform code.

The reason for such marks is that people who don't deal with a particular port can quickly skip those bugs. Cross platform changes should not be hidden from domain experts.

[Sam Weinig]

I am not sure this makes sense with regards to the direction we would like to take WebKit2.  We would like to de-emphasize frames in the UIProcess as much as possible, and will probably be remove the frame-tree aspects of frames from the UIProcess shortly.

[Carlos Garcia Campos]

Yes, our first idea was to try to keep the same WebKi1 API for WebKit2, so that apps wouldn't need to be ported. But we recently decided to start from scratch designing a new API for WebKit2, and for now, we are not adding a WebKitWebFrame class.

[Nayan Kumar K]

Comment on attachment 107298 [details]
WebKitWebFrame WebKit1 style API implementation

Clearing the review flag, as this bug is no longer valid.