Summary: | REGRESSION(r95015): compiled failed on Chromium Win bot (Requested by ukai on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ukai | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-09-12 23:07:40 PDT
Created attachment 107147 [details] ROLLOUT of r95015 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. http://build.webkit.org/builders/Chromium%20Win%20Release/builds/31236/steps/compile-webkit/logs/stdio 70>webkit_gpu.lib(webgraphicscontext3d_in_process_impl.obj) : error LNK2019: unresolved external symbol "struct GrGLInterface * __cdecl gfx::CreateInProcessSkiaGLBinding(void)" (?CreateInProcessSkiaGLBinding@gfx@@YAPAUGrGLInterface@@XZ) referenced in function "protected: virtual struct GrGLInterface * __thiscall webkit::gpu::WebGraphicsContext3DInProcessImpl::onCreateGrGLInterface(void)" (?onCreateGrGLInterface@WebGraphicsContext3DInProcessImpl@gpu@webkit@@MAEPAUGrGLInterface@@XZ) 70>E:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\Release\DumpRenderTree.exe : fatal error LNK1120: 1 unresolved externals 70>Build log was saved at "file://E:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\Release\obj\DumpRenderTree\BuildLog.htm" 70>DumpRenderTree - 2 error(s), 0 warning(s) 69>webkit_gpu.lib(webgraphicscontext3d_in_process_impl.obj) : error LNK2019: unresolved external symbol "struct GrGLInterface * __cdecl gfx::CreateInProcessSkiaGLBinding(void)" (?CreateInProcessSkiaGLBinding@gfx@@YAPAUGrGLInterface@@XZ) referenced in function "protected: virtual struct GrGLInterface * __thiscall webkit::gpu::WebGraphicsContext3DInProcessImpl::onCreateGrGLInterface(void)" (?onCreateGrGLInterface@WebGraphicsContext3DInProcessImpl@gpu@webkit@@MAEPAUGrGLInterface@@XZ) 69>E:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\Release\webkit_unit_tests.exe : fatal error LNK1120: 1 unresolved externals 69>Build log was saved at "file://E:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\Release\obj\webkit_unit_tests\BuildLog.htm" 69>webkit_unit_tests - 2 error(s), 2 warning(s) ========== Build: 67 succeeded, 3 failed, 61 up-to-date, 0 skipped ========== Comment on attachment 107147 [details] ROLLOUT of r95015 Clearing flags on attachment: 107147 Committed r95019: <http://trac.webkit.org/changeset/95019> All reviewed patches have been landed. Closing bug. It just needed to clobber (and proper setup Direct SDK paths. see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/a10379caf7390be2/dadc887130793f00?lnk=gst&q=d3dx9.h#dadc887130793f00 http://www.chromium.org/developers/how-tos/build-instructions-windows ) |