Bug 67970

Summary: [CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric, mitz, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
fixes the assertion failure hyatt: review+

Dave Hyatt
Reported 2011-09-12 16:30:18 PDT
This bug tracks adding the unprefixed border-image shorthand.
Attachments
Patch (2.16 KB, patch)
2011-09-12 16:34 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
fixes the assertion failure (2.79 KB, patch)
2011-09-12 22:09 PDT, Ryosuke Niwa 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-09-12 16:34:39 PDT
Created attachment 107108 [details] Patch
Dave Hyatt
Comment 2 2011-09-12 16:37:59 PDT
Fixed in r94989.
Ryosuke Niwa
Comment 3 2011-09-12 21:10:21 PDT
fast/borders/border-image-omit-right-slice.html started hitting an assertion after this patch: ASSERTION FAILED: unimplemented propertyID: 1041 0 /Volumes/Big/slave/snowleopard-intel-debug/build/Source/WebCore/css/SVGCSSStyleSelector.cpp(601) : void WebCore::CSSStyleSelector::applySVGProperty(int, WebCore::CSSValue*) 1 WebCore::CSSStyleSelector::applySVGProperty(int, WebCore::CSSValue*) 2 WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) 3 void WebCore::CSSStyleSelector::applyDeclarations<false>(bool, int, int) 4 WebCore::CSSStyleSelector::styleForElement(WebCore::Element*, WebCore::RenderStyle*, bool, bool, bool) 5 WebCore::Element::styleForRenderer() 6 WebCore::NodeRendererFactory::createRendererIfNeeded() 7 WebCore::Node::createRendererIfNeeded() 8 WebCore::Element::attach() 9 WTF::PassRefPtr<WebCore::Element> WebCore::HTMLConstructionSite::attach<WebCore::Element>(WebCore::ContainerNode*, WTF::PassRefPtr<WebCore::Element>) 10 WebCore::HTMLConstructionSite::attachToCurrent(WTF::PassRefPtr<WebCore::Element>) 11 WebCore::HTMLConstructionSite::insertHTMLElement(WebCore::AtomicHTMLToken&) 12 WebCore::HTMLTreeBuilder::processStartTagForInBody(WebCore::AtomicHTMLToken&) 13 WebCore::HTMLTreeBuilder::processStartTag(WebCore::AtomicHTMLToken&) 14 WebCore::HTMLTreeBuilder::processToken(WebCore::AtomicHTMLToken&) 15 WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken(WebCore::AtomicHTMLToken&) 16 WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) 17 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 18 WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 19 WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) 20 WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, unsigned long) 21 WebCore::DocumentWriter::addData(char const*, unsigned long) 22 WebCore::DocumentLoader::commitData(char const*, unsigned long) 23 -[WebFrame(WebInternal) _commitData:] 24 -[WebHTMLRepresentation receivedData:withDataSource:] 25 -[WebDataSource(WebInternal) _receivedData:] 26 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) 27 WebCore::DocumentLoader::commitLoad(char const*, int) 28 WebCore::DocumentLoader::receivedData(char const*, int) 29 WebCore::MainResourceLoader::addData(char const*, int, bool) 30 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) 31 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool)
Ryosuke Niwa
Comment 4 2011-09-12 22:09:42 PDT
Created attachment 107144 [details] fixes the assertion failure
Ryosuke Niwa
Comment 5 2011-09-13 09:46:02 PDT
Reopen.
Dave Hyatt
Comment 6 2011-09-13 10:26:09 PDT
Comment on attachment 107144 [details] fixes the assertion failure r=me
Ryosuke Niwa
Comment 7 2011-09-13 10:30:51 PDT
Committed r95031: <http://trac.webkit.org/changeset/95031>
Note You need to log in before you can comment on or make changes to this bug.