Summary: | Implement a HashChangeEvent constructor for V8 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, dominicc, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 67824 | ||||||
Attachments: |
|
Description
Kentaro Hara
2011-09-12 16:24:16 PDT
Created attachment 107106 [details]
Patch
Comment on attachment 107106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > Source/WebCore/dom/HashChangeEvent.idl:26 > - CustomConstructFunction > + CustomConstructFunction, > + V8CustomConstructor It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them? Comment on attachment 107106 [details]
Patch
Haraken should respond Chapin's comment.
Comment on attachment 107106 [details] Patch Clearing flags on attachment: 107106 Committed r95063: <http://trac.webkit.org/changeset/95063> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 107106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > > > Source/WebCore/dom/HashChangeEvent.idl:26 > > - CustomConstructFunction > > + CustomConstructFunction, > > + V8CustomConstructor > > It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them? Sure! I will do it sometime soon. |