Bug 67896

Summary: Web Inspector: Profiler: Overlapping data in function names column
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch pfeldman: review+, mnaganov: commit-queue-

Description Mikhail Naganov 2011-09-10 15:03:55 PDT
Two problems, but of a similar kind.

From http://code.google.com/p/chromium/issues/detail?id=92526:

Google Chrome	15.0.849.0 (Official Build 96325) dev
OS tested: Gunbutu lucid (10.4)

What steps will reproduce the problem?
1.launch chrome
2.navigate to amazon.com
3.ctrl+shfit+i to bring up devtool
4. go to profile, click start profiling
5. navigate to some items in amazon
6. observe the profile saved

What is the expected output? What do you see instead?
all URL links should be properly list under function dropdown menu in Function column.

currently those very long URl link will overlap the function name, especially when this function menu dropdown has sub-menu. URL link will overlap the function name pretty badly.

From http://code.google.com/p/chromium/issues/detail?id=95904:

What steps will reproduce the problem?
1.Open the browser.
2.Open the mentioned URL.
3.Open DevTools (Ctrl+Shift+I on Win/Linux, Command+Option+I on Mac)
4.Go to 'Profiles' page
5.Press 'Take heap snapshot' button (eye icon on the left side of status bar)
6.Now Click on the Snapshot 1
7.Now in the right side column "Constructor" keep expanding the items.Now we can see the
Overlapping of Column data to next column area.

What is the expected result?
Should not be overlapped to next column data area.

What happens instead?
Overlapping column data of Snapshot to next column data area in the Profiles.
Comment 1 Mikhail Naganov 2011-09-10 15:06:27 PDT
Created attachment 106985 [details]
Comment 2 Pavel Feldman 2011-09-13 02:38:04 PDT
Comment on attachment 106985 [details]

Could you please make sure that it does not break the network panel and cookies grids.
Comment 3 Mikhail Naganov 2011-09-13 08:18:37 PDT
(In reply to comment #2)
> (From update of attachment 106985 [details])
> Could you please make sure that it does not break the network panel and cookies grids.

Thanks! Both grids look OK.

table-layout:fixed prescribes to use column width specified in style, not calculate them based on contents length (otherwise, if you have oversized contents, columns widths can be adjusted and the resulting table can be wider than specified in style rules);
and overflow:hidden cuts off contents that overflow columns.

I guess, both network panel and cookies don't requre an opposite behaviour.
Comment 4 Mikhail Naganov 2011-09-13 08:32:50 PDT
Manually committed: http://trac.webkit.org/changeset/95027

2011-09-10  Mikhail Naganov  <mnaganov@chromium.org>

        Web Inspector: Profiler: Fix overlapping data in function names column.

        Reviewed by Pavel Feldman.

        * inspector/front-end/ProfileDataGridTree.js:
        * inspector/front-end/dataGrid.css:
        (.data-grid table.data):
        (.data-grid td):