| Summary: | [Chromium] The checked state of WebPopupMenuItem isn't initialized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fishd, peter, steveblock, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 66687 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-09-10 01:53:28 PDT
Created attachment 106973 [details]
Patch
I don't fully understand this patch. If someone else can explain why this diff exists in the Android branch, I'd appreciate that. Comment on attachment 106973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106973&action=review > Source/WebKit/chromium/ChangeLog:10 > + use popup menus for <select> elements. the mac port uses "external" popup menus for select elements too. this parch seems fine to me, but i'd also like to know the answer to your question. perhaps jcivelli knows? The WebMenuItemInfo struct contained the checked property already, but since it wasn't being set in the ExternalPopupMenu::getPopupMenuInfo method it didn't propagate correctly to Chrome. The information will be used for implementing select boxes which accept multiple answers, for which we'll indeed need an external menu. Comment on attachment 106973 [details]
Patch
Ok.
Comment on attachment 106973 [details] Patch Clearing flags on attachment: 106973 Committed r95045: <http://trac.webkit.org/changeset/95045> All reviewed patches have been landed. Closing bug. |