Summary: | Generate a SharedWorker constructor of V8 using the IDL 'Constructor' extended attribute | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, ap, dominicc, haraken, sam, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 65839 | ||||||||||||
Attachments: |
|
Description
Kentaro Hara
2011-09-09 18:57:56 PDT
Created attachment 107020 [details]
Patch
Created attachment 108986 [details]
rebased patch for review
Created attachment 110114 [details]
rebased patch for review
Comment on attachment 107020 [details]
Patch
Marking obsolete as new one being available.
Comment on attachment 110114 [details]
rebased patch for review
RIP out poor custom constructor.
By the way, could you add a new test which verifies "name" parameter of SharedWorker?
I guess we don't have any test which checks worker side stuff.
(In reply to comment #5) > (From update of attachment 110114 [details]) > By the way, could you add a new test which verifies "name" parameter of SharedWorker? > I guess we don't have any test which checks worker side stuff. Isn't fast/workers/shared-worker-name.html enough? Created attachment 111247 [details]
Patch
(In reply to comment #5) > (From update of attachment 110114 [details]) > RIP out poor custom constructor. > By the way, could you add a new test which verifies "name" parameter of SharedWorker? > I guess we don't have any test which checks worker side stuff. morrita: Upon rebase, I needed to make a non-trivial change. Would you please take another look at the patch? - Moved a ScriptExecutionContext parameter of SharedWorker::create() to the beginning, i.e. SharedWorker::create(..., context, ec) ==> SharedWorker::create(context, ..., ec). c.f. bug 69799. - Added test cases for an undefined name and a null name on fast/workers/resources/shared-worker-name.js. Comment on attachment 111247 [details] Patch Clearing flags on attachment: 111247 Committed r97836: <http://trac.webkit.org/changeset/97836> All reviewed patches have been landed. Closing bug. |