Bug 67879

Summary: Generate a SharedWorker constructor of V8 using the IDL 'Constructor' extended attribute
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, haraken, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65839    
Attachments:
Description Flags
Patch
none
rebased patch for review
none
rebased patch for review
none
Patch none

Kentaro Hara
Reported 2011-09-09 18:57:56 PDT
Currently, the SharedWorker constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute.
Attachments
Patch (11.28 KB, patch)
2011-09-11 22:13 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for review (11.23 KB, patch)
2011-09-28 02:03 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for review (11.28 KB, patch)
2011-10-07 02:53 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (18.07 KB, patch)
2011-10-17 05:16 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-11 22:13:11 PDT
Created attachment 107020 [details] Patch
Kentaro Hara
Comment 2 2011-09-28 02:03:44 PDT
Created attachment 108986 [details] rebased patch for review
Kentaro Hara
Comment 3 2011-10-07 02:53:49 PDT
Created attachment 110114 [details] rebased patch for review
Hajime Morrita
Comment 4 2011-10-16 22:34:14 PDT
Comment on attachment 107020 [details] Patch Marking obsolete as new one being available.
Hajime Morrita
Comment 5 2011-10-16 22:41:57 PDT
Comment on attachment 110114 [details] rebased patch for review RIP out poor custom constructor. By the way, could you add a new test which verifies "name" parameter of SharedWorker? I guess we don't have any test which checks worker side stuff.
Kentaro Hara
Comment 6 2011-10-17 00:18:02 PDT
(In reply to comment #5) > (From update of attachment 110114 [details]) > By the way, could you add a new test which verifies "name" parameter of SharedWorker? > I guess we don't have any test which checks worker side stuff. Isn't fast/workers/shared-worker-name.html enough?
Kentaro Hara
Comment 7 2011-10-17 05:16:34 PDT
Created attachment 111247 [details] Patch
Kentaro Hara
Comment 8 2011-10-17 05:21:28 PDT
(In reply to comment #5) > (From update of attachment 110114 [details]) > RIP out poor custom constructor. > By the way, could you add a new test which verifies "name" parameter of SharedWorker? > I guess we don't have any test which checks worker side stuff. morrita: Upon rebase, I needed to make a non-trivial change. Would you please take another look at the patch? - Moved a ScriptExecutionContext parameter of SharedWorker::create() to the beginning, i.e. SharedWorker::create(..., context, ec) ==> SharedWorker::create(context, ..., ec). c.f. bug 69799. - Added test cases for an undefined name and a null name on fast/workers/resources/shared-worker-name.js.
WebKit Review Bot
Comment 9 2011-10-18 23:56:45 PDT
Comment on attachment 111247 [details] Patch Clearing flags on attachment: 111247 Committed r97836: <http://trac.webkit.org/changeset/97836>
WebKit Review Bot
Comment 10 2011-10-18 23:56:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.