Summary: | Cookies are not available after turning off Private Browsing after the last window has been closed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebCore Misc. | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | adachan, andersca, ap, jberlin, mitz, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jessie Berlin
2011-09-09 16:31:17 PDT
Created attachment 106940 [details]
Patch
The references to the PageGroup updating the settings after the Page is created in the comments are wrong. It should be the WebPage, not the PageGroup. I will fix the comments. Comment on attachment 106940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106940&action=review > Source/WebCore/ChangeLog:20 > + global value for the storage session from being destroyed. Is "from being reset" better? (In reply to comment #3) > (From update of attachment 106940 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106940&action=review > > > Source/WebCore/ChangeLog:20 > > + global value for the storage session from being destroyed. > > Is "from being reset" better? Actually what you have is fine. Nevermind. Comment on attachment 106940 [details] Patch Thanks for the review! Committed in http://trac.webkit.org/changeset/94892. |