Bug 67853

Summary: Add myself to committers.py
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: Tools / TestsAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2011-09-09 09:49:35 PDT
See summary.
Attachments
Patch (1.39 KB, patch)
2011-09-09 09:54 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2011-09-09 10:13 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-09-09 09:54:04 PDT
Created attachment 106882 [details] Patch
WebKit Review Bot
Comment 2 2011-09-09 09:54:40 PDT
Comment on attachment 106882 [details] Patch Rejecting attachment 106882 [details] from commit-queue. mhahnenberg@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Review Bot
Comment 3 2011-09-09 10:09:34 PDT
Comment on attachment 106882 [details] Patch Rejecting attachment 106882 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: working directory Updating working directory Processing patch 106882 from bug 67853. ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9622885
Mark Hahnenberg
Comment 4 2011-09-09 10:13:33 PDT
Created attachment 106884 [details] Patch
WebKit Review Bot
Comment 5 2011-09-09 11:16:38 PDT
Comment on attachment 106884 [details] Patch Clearing flags on attachment: 106884 Committed r94867: <http://trac.webkit.org/changeset/94867>
WebKit Review Bot
Comment 6 2011-09-09 11:16:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.