Bug 67837
| Summary: | Web Inspector: [Chromium] Valgrind signals use of uninitialized field in InspectorStyleSheetForInlineStyle | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> |
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Alexander Pavlov (apavlov)
m_isStyleTextValid is not initialized in the ctor and seemingly results in valgrind errors.
Upstreaming http://crbug.com/87380
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexander Pavlov (apavlov)
Committed r94844: <http://trac.webkit.org/changeset/94844>
Joseph Pecoraro
Good catch and fix.
I just happened to open up the bug and see no attached patch but a committed
changeset. I think maybe this change should still have had a reviewer (even
simple, non-build issues typically have reviews) but certainly a ChangeLog.
In either case keep up the good fixes!
Alexander Pavlov (apavlov)
(In reply to comment #2)
> Good catch and fix.
>
> I just happened to open up the bug and see no attached patch but a committed
> changeset. I think maybe this change should still have had a reviewer (even
> simple, non-build issues typically have reviews) but certainly a ChangeLog.
> In either case keep up the good fixes!
Well, the change seemed trivial, so Pavel who was on vacation and was having difficulties doing the actual review (i.e. setting r+), said that it could surely be committed unreviewed (even though the change had a reviewer de facto, and there were no other reviewers around). I'll do my best finding a real reviewer from now on.
Joseph Pecoraro
It wasn't so much the review (I trust your judgement with the small change)
it was the Missing ChangeLog that I wanted to call out. Either way thanks
for the explanation!
Joseph Pecoraro
Also changes like this are easy to get a quick review from someone in
#webkit if you need one. Or people like Darin are always checking the
list of patches for review and might review without even being CC'd!
Joseph Pecoraro
(In reply to comment #4)
> It wasn't so much the review (I trust your judgement with the small change)
> it was the Missing ChangeLog that I wanted to call out. Either way thanks
> for the explanation!
As you rightly pointed out, there was a ChangeLog. I don't know how I missed that =(.
Thanks for following up.