Bug 67830

Summary: Rebaseline for bug 65583 (path based border radius drawing on skia) part 3
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, koz, mikelawther, senorblanco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Pretty diff without 'Binary file, nothing to see' problems
none
Patch
none
Patch none

Ben Wells
Reported 2011-09-08 20:48:55 PDT
Rebaseline for bug 65583 (path based border radius drawing on skia) part 3
Attachments
Patch (374.06 KB, patch)
2011-09-08 21:10 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Pretty diff without 'Binary file, nothing to see' problems (640.34 KB, text/html)
2011-09-08 21:18 PDT, Ben Wells 		no flags
Details
Patch (357.38 KB, patch)
2011-09-11 20:14 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Patch (357.39 KB, patch)
2011-09-11 20:25 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-09-08 21:10:41 PDT
Created attachment 106836 [details] Patch
Ben Wells
Comment 2 2011-09-08 21:18:08 PDT
Created attachment 106837 [details] Pretty diff without 'Binary file, nothing to see' problems
Ben Wells
Comment 3 2011-09-08 21:25:46 PDT
Comment on attachment 106836 [details] Patch A couple of comments: 1. LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDashed06-expected.png doesn't look great; its because of bug 58711, and also because of differences in how CG and skia do dashed / dotted strokes. I'd like to fix this in a separate patch, let me know if this should be left out of teh rebaseline (i.e. left as a known failure) 2. There is a html file posted which shows the diff wihtout the 'binary file' problems being addressed in bug 67628. Ignore the PrettyPatch.rb changes at the end, they are the fixes to generate the pretty diff.
Kenneth Russell
Comment 4 2011-09-09 15:47:18 PDT
Comment on attachment 106836 [details] Patch These all look good except for fast/borders/borderRadiusDashed06-expected.png as you pointed out. Yes, please leave this one as an expected failure. I'll r+ this but cq- it since you're not yet a committer and won't be able to just leave that change out when landing the patch. I think you ought to be able to upload a new patch and have any committer cq+ it without another r+, but if that doesn't seem to work let me know.
Ben Wells
Comment 5 2011-09-11 20:14:19 PDT
Created attachment 107014 [details] Patch
Ben Wells
Comment 6 2011-09-11 20:25:16 PDT
Created attachment 107016 [details] Patch
James Kozianski
Comment 7 2011-09-11 20:34:12 PDT
Comment on attachment 107016 [details] Patch Clearing flags on attachment: 107016 Committed r94941: <http://trac.webkit.org/changeset/94941>
James Kozianski
Comment 8 2011-09-11 20:34:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.