| Summary: | Rebaseline for bug 65583 (path based border radius drawing on skia) part 3 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Wells <benwells> | ||||||||||
| Component: | New Bugs | Assignee: | Ben Wells <benwells> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | jamesr, kbr, koz, mikelawther, senorblanco | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ben Wells
2011-09-08 20:48:55 PDT
Created attachment 106836 [details]
Patch
Created attachment 106837 [details]
Pretty diff without 'Binary file, nothing to see' problems
Comment on attachment 106836 [details] Patch A couple of comments: 1. LayoutTests/platform/chromium-linux/fast/borders/borderRadiusDashed06-expected.png doesn't look great; its because of bug 58711, and also because of differences in how CG and skia do dashed / dotted strokes. I'd like to fix this in a separate patch, let me know if this should be left out of teh rebaseline (i.e. left as a known failure) 2. There is a html file posted which shows the diff wihtout the 'binary file' problems being addressed in bug 67628. Ignore the PrettyPatch.rb changes at the end, they are the fixes to generate the pretty diff. Comment on attachment 106836 [details]
Patch
These all look good except for fast/borders/borderRadiusDashed06-expected.png as you pointed out. Yes, please leave this one as an expected failure. I'll r+ this but cq- it since you're not yet a committer and won't be able to just leave that change out when landing the patch. I think you ought to be able to upload a new patch and have any committer cq+ it without another r+, but if that doesn't seem to work let me know.
Created attachment 107014 [details]
Patch
Created attachment 107016 [details]
Patch
Comment on attachment 107016 [details] Patch Clearing flags on attachment: 107016 Committed r94941: <http://trac.webkit.org/changeset/94941> All reviewed patches have been landed. Closing bug. |