Bug 6782

Summary:

REGRESSION: replaceChild broken when node to replace is first (TinyMCE test app broken)

Product:

WebKit

Reporter:

Justin Garcia <justin.garcia>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

6644

Attachments:

Description	Flags
fix problem in replaceChild that was breaking TinyMCE	none

Justin Garcia

Reported 2006-01-24 18:29:26 PST

Goto: http://tinymce.moxiecode.com/example.php?example=true Compare the test app in TOT and an r12282 or earlier nightly build. The app looks partially loaded. This is sent to stderr in a development build: (event handler): Undefined value

Attachments
fix problem in replaceChild that was breaking TinyMCE (4.00 KB, patch) 2006-01-24 21:12 PST, Darin Adler	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Justin Garcia

Comment 1 2006-01-24 20:03:24 PST

Eric thought that his changes to 5874 might have caused this regression, since they played with event handling. I've rolled out those changes and those from 5964 (since they touched some of the changes made for 5874), but the problem still exists.

Darin Adler

Comment 2 2006-01-24 20:46:41 PST

The "undefined" thing here is the contentWindow of an <iframe> element. I see HTMLFrameElementImpl::contentPart returning 0.

Darin Adler

Comment 3 2006-01-24 20:56:53 PST

At the time contentWindow is called, the <iframe> element is not yet inserted into a document.

Darin Adler

Comment 4 2006-01-24 21:04:45 PST

Figured it out. Have a reduced test case and a fix.

Darin Adler

Comment 5 2006-01-24 21:12:06 PST

Created attachment 5938 [details] fix problem in replaceChild that was breaking TinyMCE

Eric Seidel (no email)

Comment 6 2006-01-24 21:55:04 PST

Comment on attachment 5938 [details] fix problem in replaceChild that was breaking TinyMCE Looks good. r=me.

Darin Adler

Comment 7 2006-01-24 22:02:18 PST

Comment on attachment 5938 [details] fix problem in replaceChild that was breaking TinyMCE Clearing the flag on this one because there is a patch in bug 6784 that fixes both this bug and that one.

Note You need to log in before you can comment on or make changes to this bug.