Bug 67800

Summary: Implement a ProgressEvent constructor for V8
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, dominicc, hayato, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sam: review+
Just to see if the patch passes win EWS
none
Just see if this patch passes win EWS
none
Just see if the patch passes win EWS none

Description Kentaro Hara 2011-09-08 13:33:06 PDT
ProgressEvent should have a constructor (Spec: http://www.w3.org/TR/progress-events/#interface-progressevent).
Comment 1 Kentaro Hara 2011-09-08 13:38:18 PDT
Created attachment 106781 [details]
Patch
Comment 2 Adam Barth 2011-09-08 13:50:34 PDT
Comment on attachment 106781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106781&action=review

> Source/WebCore/bindings/v8/OptionsObject.h:38
> +static const double UnsignedLongLongMax = 18446744073709551616.0; // 2^64

Why don't we get this from limits.h?
Comment 3 Kentaro Hara 2011-09-08 14:21:00 PDT
Created attachment 106786 [details]
Patch
Comment 4 Kentaro Hara 2011-09-08 14:22:08 PDT
Comment on attachment 106781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106781&action=review

>> Source/WebCore/bindings/v8/OptionsObject.h:38
>> +static const double UnsignedLongLongMax = 18446744073709551616.0; // 2^64
> 
> Why don't we get this from limits.h?

Done.
Comment 5 WebKit Review Bot 2011-09-08 23:27:33 PDT
Comment on attachment 106786 [details]
Patch

Attachment 106786 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9622650
Comment 6 Kentaro Hara 2011-09-09 09:24:50 PDT
Created attachment 106880 [details]
Patch
Comment 7 Sam Weinig 2011-09-09 10:47:25 PDT
Comment on attachment 106880 [details]
Patch

It seems this breaks windows.  If you fix that, r=me.
Comment 8 Kentaro Hara 2011-09-09 12:31:57 PDT
(In reply to comment #7)
> (From update of attachment 106880 [details])
> It seems this breaks windows.  If you fix that, r=me.

Sam: Thank you very much for reviews. By the way, the windows problem seems not to be related to this patch. We can find similar failures in the waterfall (http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/10647/steps/compile-webkit/logs/stdio). I will wait for this failure to be fixed, and then commit my patch.
Comment 9 Kentaro Hara 2011-09-09 14:08:41 PDT
Created attachment 106918 [details]
Just to see if the patch passes win EWS

I will postpone committing the patch until windows build problem is fixed.
Comment 10 Kentaro Hara 2011-09-09 15:23:32 PDT
Created attachment 106930 [details]
Just see if this patch passes win EWS

Replaced ULONG_LONG_MAX with std::numeric_limits<unsigned long long>::max().
Comment 11 Kentaro Hara 2011-09-11 21:17:17 PDT
Created attachment 107018 [details]
Just see if the patch passes win EWS

Just rebased the patch.
Comment 12 Hayato Ito 2011-09-11 22:46:00 PDT
Committed r94946: <http://trac.webkit.org/changeset/94946>