Bug 67800

Summary: Implement a ProgressEvent constructor for V8
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, dominicc, hayato, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sam: review+
Just to see if the patch passes win EWS
none
Just see if this patch passes win EWS
none
Just see if the patch passes win EWS none

Kentaro Hara
Reported 2011-09-08 13:33:06 PDT
ProgressEvent should have a constructor (Spec: http://www.w3.org/TR/progress-events/#interface-progressevent).
Attachments
Patch (5.54 KB, patch)
2011-09-08 13:38 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (6.46 KB, patch)
2011-09-08 14:21 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (6.94 KB, patch)
2011-09-09 09:24 PDT, Kentaro Hara 		sam: review+
DetailsFormatted DiffDiff
Just to see if the patch passes win EWS (6.40 KB, patch)
2011-09-09 14:08 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Just see if this patch passes win EWS (6.48 KB, patch)
2011-09-09 15:23 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Just see if the patch passes win EWS (6.56 KB, patch)
2011-09-11 21:17 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-08 13:38:18 PDT
Created attachment 106781 [details] Patch
Adam Barth
Comment 2 2011-09-08 13:50:34 PDT
Comment on attachment 106781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106781&action=review > Source/WebCore/bindings/v8/OptionsObject.h:38 > +static const double UnsignedLongLongMax = 18446744073709551616.0; // 2^64 Why don't we get this from limits.h?
Kentaro Hara
Comment 3 2011-09-08 14:21:00 PDT
Created attachment 106786 [details] Patch
Kentaro Hara
Comment 4 2011-09-08 14:22:08 PDT
Comment on attachment 106781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106781&action=review >> Source/WebCore/bindings/v8/OptionsObject.h:38 >> +static const double UnsignedLongLongMax = 18446744073709551616.0; // 2^64 > > Why don't we get this from limits.h? Done.
WebKit Review Bot
Comment 5 2011-09-08 23:27:33 PDT
Comment on attachment 106786 [details] Patch Attachment 106786 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9622650
Kentaro Hara
Comment 6 2011-09-09 09:24:50 PDT
Created attachment 106880 [details] Patch
Sam Weinig
Comment 7 2011-09-09 10:47:25 PDT
Comment on attachment 106880 [details] Patch It seems this breaks windows. If you fix that, r=me.
Kentaro Hara
Comment 8 2011-09-09 12:31:57 PDT
(In reply to comment #7) > (From update of attachment 106880 [details]) > It seems this breaks windows. If you fix that, r=me. Sam: Thank you very much for reviews. By the way, the windows problem seems not to be related to this patch. We can find similar failures in the waterfall (http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/10647/steps/compile-webkit/logs/stdio). I will wait for this failure to be fixed, and then commit my patch.
Kentaro Hara
Comment 9 2011-09-09 14:08:41 PDT
Created attachment 106918 [details] Just to see if the patch passes win EWS I will postpone committing the patch until windows build problem is fixed.
Kentaro Hara
Comment 10 2011-09-09 15:23:32 PDT
Created attachment 106930 [details] Just see if this patch passes win EWS Replaced ULONG_LONG_MAX with std::numeric_limits<unsigned long long>::max().
Kentaro Hara
Comment 11 2011-09-11 21:17:17 PDT
Created attachment 107018 [details] Just see if the patch passes win EWS Just rebased the patch.
Hayato Ito
Comment 12 2011-09-11 22:46:00 PDT
Committed r94946: <http://trac.webkit.org/changeset/94946>
Note You need to log in before you can comment on or make changes to this bug.